Shadow and Highlight clipping buttons

[tomczak]

A few comments on the new implementation:

- I would find reversing the placement of the buttons more intuitive: shadow on the left of highlights - just like an x-axis in a histogram

- For clipped highlight button: any channel clipped vs. all channels clipped seems to work fine, but those two choices also work work for shadow clipping, where All Channels choice is larger than single chanel blocking - I'm not sure if I understand it.

- The icons for the Any Channel Clipped and All Channel Clipped are ok, but I don't find them intuitive.

Thanks for implementing it!
-

[jsachs]

Highlight is on the left since it is the one most often used so it goes first.

For any channel, the HSV value (max of r,g,b) is checked against the threshold
For all channels, the HSL value is checked instead. For black it makes almost no difference.

[tomczak]

Ok, thanks, makes sense. This is nitpicking, and it's probably me, but the color hexagon on the HSV (any colour) clipping confused me because it's being used in a couple of other places, maybe not as an icon, but I still associate it with Selective Colour correction etc. But on second thought, it is logical for any colour clipping just as white square symbolizes pure white (all colours).

[jsachs]

I fixed this for the next release -- better clipping algorithm and better icons.